[2 of 2] Remove needs_consent_follow_up_requested#6659
Open
murugapl wants to merge 4 commits intohas-refusal-follow-up-requestedfrom
Open
[2 of 2] Remove needs_consent_follow_up_requested#6659murugapl wants to merge 4 commits intohas-refusal-follow-up-requestedfrom
murugapl wants to merge 4 commits intohas-refusal-follow-up-requestedfrom
Conversation
…requested A parent can only request a follow-up discussion through a consent refusal. Hence, it makes sense for "follow-up requested" to be a substatus of "has a refusal" rather than "needs consent". This commit modifies the code to use has_a_refusal as the parent status. We retain needs_consent_follow_up_requested for now, and can remove it in a future commit when all patients have had their status updated appropriately.
With the post-deploy task all patients with needs_consent_follow_up_requested should be updated to has_a_refusal_follow_up_requested. This means we can hide the checkbox under needs consent till we remove the status altogether in a follow-up PR.
The parent status should now be "Has a refusal" not "Needs consent"
thomasleese
reviewed
Apr 21, 2026
| def up | ||
| Patient::ProgrammeStatus | ||
| .where(status: :needs_consent_follow_up_requested) | ||
| .where(status: 14) |
Contributor
There was a problem hiding this comment.
Might be worth just adding a comment here explaining what this value used to represent.
Contributor
Author
There was a problem hiding this comment.
Ah this was from the other PR, just rebased!
murugapl
force-pushed
the
has-refusal-follow-up-requested
branch
from
b5671ac to
3c37a44
Compare
In 2aac45f, we removed any use of the needs_consent_follow_up_requested sattus, and instead migrated to has_refusal_follow_up_requested. This status can now be completely removed from the code base as all patients should have the new status now.
murugapl
force-pushed
the
remove-needs-consent-follow-up
branch
from
f02f33a to
97178bc
Compare
murugapl
force-pushed
the
has-refusal-follow-up-requested
branch
2 times, most recently
from
24b1874 to
9767f22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2aac45f, we removed any use of the needs_consent_follow_up_requested sattus, and instead migrated to has_refusal_follow_up_requested. This status can now be completely removed from the code base as all patients should have the new status now.
Jira Issue - MAV-6744